Coding Horror

iLikeWaffles · 25-07-2021 4:44pm

test

iLikeWaffles · 25-07-2021 4:44pm

test


test

iLikeWaffles · 25-07-2021 4:45pm

test

iLikeWaffles · 25-07-2021 4:51pm

lol

iLikeWaffles · 25-07-2021 4:52pm

tset

iLikeWaffles · 25-07-2021 4:53pm

feel free to delete no issue in this on this page of the thread with a codeblock. Unless it is the use of multiple codeblocks in a thread?!

the_amazing_raisin · 25-07-2021 7:48pm

https://www.boards.ie/discussion/comment/117659781#Comment_117659781

I was wondering if this thread was becoming the definition of it's title 😁

Anesthetize · 29-07-2021 9:08pm

^ Was that the forum equivalent of adding "Here" print statements while trying to debug your code? 😄

Mr. CooL ICE · 07-04-2022 9:07am

DATEADD(day, -6+14, getdate())

Like, it being a parameter in dateadd(), I assume it has to be 6 days before a two week period, but writing this way must have meant something to the developer (long gone) who wrote this. But why not just put in 8 and add a comment? Bizarre

FobleAsNuck · 07-04-2022 2:20pm

https://www.ctrl.blog/entry/apple-music-nullbytes.html

>The music files you purchase from the Apple Music Store (AMS; formerly the iTunes Music Store) contain approximately 6 % of the digital equivalent of nothingness. I’m not referring to silence, but continuous blocks of empty space set aside inside the files. It serves no purpose other than to pad the files to make them 0,5 MB larger.

Mr. CooL ICE · 10-08-2022 2:37pm

Again, less a horror and more a jaded previous developer. In this case, a simple RETURN -1 could have sufficed:

IF TRUE
	-- Do SQL-ey stuff
ELSE
BEGIN
	PRINT 'today is not the day to do this';
END;

d mc · 04-04-2023 7:05pm

public class Order
{
    public int Id { get; set; }
    public int Quantity { get; set }
}

Somewhere in a PR....

David, your code coverage has dropped.....

...

But I only added one class...

...

But we can't let our coverage drop ...

*deep sigh*

[Test]
public void DumbestFuckingTestOnEarth()
{
    var order = new Order 
    {
        Id = 7,
        Quantity = 100
    };

    Assert.Equal(order.Id, 7);
    Assert.Equal(order.Quantity, 100);
}

Great job David!

PommieBast · 04-04-2023 7:21pm

A few companies ago we were told that the code coverage was too low. Turned out the devel who got the best increase in coverage did so by stripping out various sanity checks. 😖

Anesthetize · 06-04-2023 9:11pm

I assume that the class(es) that are using that new Order class already have their own unit tests? Did the code you modified to use an Order object not already have unit test coverage?

It looks like an issue with existing test coverage.

d mc · 13-04-2023 11:46am

https://www.boards.ie/discussion/comment/120449523#Comment_120449523

My point was - the tests I had to add to raise coverage was effectvely unit testing the get set properties provider by .net... completely useless

var x = 5

Assert.Equal(x, 5)

Colonel Panic · 13-04-2023 7:55pm

So are there tests that use the Order POCO or not? Apart from the pointless ones you list.

RickBlaine · 08-09-2023 10:22am

Not the worst offense but I was looking at a method I wrote myself in a personal project a few months ago and found code structured like this:

if (myObject is null)
{
   myObject = new myObject();
   DoSomething(myObject);
} else 
{
   DoSomething(myObject);
}

Not sure what I was thinking at the time. I guess I wasn't thinking clearly in the middle of a late night coding session. I refactored it to:

if (myObject is null)
{
   myObject = new myObject();
}
DoSomething(myObject);

the_amazing_raisin · 08-09-2023 12:35pm

https://www.boards.ie/discussion/comment/121084087#Comment_121084087

There's a point where caffeine can no longer help 😂

GreeBo · 10-09-2023 10:10pm

Trying to debug an issue this week and found that the code has been deliberately changed from the original code to create the bug.

Checked the git commit message to find:

"Making the code changes as per the user story"

No mention of the story of course. FML.

the_amazing_raisin · 11-09-2023 8:55pm

https://www.boards.ie/discussion/comment/121094802#Comment_121094802

Ah, this is what you call job security. Write deliberately buggy or poorly optimised code for the initial release

Then in the weeks before your annual review you suddenly roll out a bunch of "improvements" and put down a 500% performance enhancement as your accomplishments for the year

I'm guessing since you're fixing someone else's code that strategy didn't work for them 😂

GreeBo · 11-09-2023 9:10pm

https://www.boards.ie/discussion/comment/121098772#Comment_121098772

Well when I say "deliberately changed" I dont mean they made a bug on purpose. More that the result was the expected result.

But now no one knows why as the requirement is unavailable.

Its people like this who dont have any understanding of why we have coding and check-in standards and they get annoyed when the commit hook fails their check-in so they just put in rubbish.

daymobrew · 12-09-2023 11:43am

Was the company paying people to fix bugs per the Dilbert classic: https://www.reddit.com/r/ProgrammerHumor/comments/k5hka0/bug_free_programs_a_dilbert_classic/

GreeBo · 14-09-2023 1:02pm

https://www.boards.ie/discussion/comment/121100412#Comment_121100412

No, it was part of another requirements change....just no one know what or why now, since the commit comment doesnt refer to anything.

DublinWriter · 02-10-2023 3:51pm

I worked as a 'code monkey' for most of my career, before landing a hands-on IT Project Leader for a big multinational in the mid-90s.

In the second week there, the IT Manager came in and plonked a bill from Eircom for £20,000IEP for a months worth of usage on an ISDN line we had linking our Dublin office to our Belfast office so they could run a terminal session to our IBM AS/400.

A week later, the Belfast office get a £17,000GBP bill from BT for the same ISDN line for the same period.

The link should be costing the company around £400 a month to operate, but suddenly it's now £40,000.

Just before I joined, the company had employed a small two-man Dublin based company to set up the ISDN network link between the two offices and the Netware file server in the Belfast office.

I contact the initial two man company who set up the link, but they're next to useless.

Coming from a coding background, I pull out the gigantic ring-binder manual for the Cisco router and get cracking. I also get hold of some packet sniffing software. It's all new to me and totally daunting.

Again, this is going to turn into a long IT war-story, so let me know if you want Part II.