Advertisement
If you have a new account but are having problems posting or verifying your account, please email us on hello@boards.ie for help. Thanks :)
Hello all! Please ensure that you are posting a new thread or question in the appropriate forum. The Feedback forum is overwhelmed with questions that are having to be moved elsewhere. If you need help to verify your account contact hello@boards.ie
Hi all,
Vanilla are planning an update to the site on April 24th (next Wednesday). It is a major PHP8 update which is expected to boost performance across the site. The site will be down from 7pm and it is expected to take about an hour to complete. We appreciate your patience during the update.
Thanks all.
Vanilla are planning an update to the site on April 24th (next Wednesday). It is a major PHP8 update which is expected to boost performance across the site. The site will be down from 7pm and it is expected to take about an hour to complete. We appreciate your patience during the update.
Thanks all.
Coding Horror
Comments
-
-
I work in a sh1thole (commonly referred to as a financial institution). So we get this guy in that was just a horror, and after a few months I beg for the guy to be fired, which of course doesn't happen, and lo and behold we're left with 2 years of mess.
Coding horrors don't just happen in isolation, you need someone with an almost narcissistic belief in their skills and a matching aggressive streak just to liven up things. Like when I needed to run thru' code like this:if (condition == true) some block of code else if (condition == false) some block of code else the block of code I needed to run
... it takes me 30 seconds to see to the problem (it was about 20 lines of code), and involves a 30 minute argument with the owner (who always kept their code - and half the rest checkout out to themselves) - eventually shouting at me "WHAT DO YOU WANT ME TO DO" even though I've explained it 5 times at this stage. Never trust anyone who can't read their own code
When the guy had been let go (I wish they had let me go and kept him - they're a much better match), I found myself cleaning and commenting a lot of the system - those bits I could. All these comments would have been on his code.//[dd] [functionxxx] is supposed to be a class function, but it is only called // in an instantiated version of the already existing class, and it returns // a second instance - real stupidity - its leaking like a rusty bucket. //[dd] 30.10.2007 This is so broken its not even funny // I've depreciated due to the reference to PropList //[dd] For the time being - just find the respective node, and pretend it has // been clicked. Its wasteful but... what the fcuk are you to do in this // mess? really??? //[dd] 16.11.2007 Removed Delete Proposal - WTF was this added in the first place? //[dd] 25.09.2007 [function name] - WTF is this in [unit] and not here??? // It doesn't appear to be referenced anywhere else, I've moved it here aNewPanel := CustomerPanel; Ntype := 'CUST'; // <--- wtf is this about? ntype? {----- comment--- This method below was required because of problems with *** sufacing message record changed by another user etc This method is used after a save to resolve the *** issues. ----- new comment there probably isn't any problem - its just the screen has been written by an idiot. //[dd] FFS popping up a messagebox inside a transaction is fupping criminal //[dd] 19.12.2007 THIS SHOULDN'T BE HERE FFS. //FFS main. <- this is sick
This one is interesting, because as the framework was coming together there were stubs written that had no proper implementation at that time. One was focused on in a meeting and Narcissist coder freak comes out with the classic line "Oh you'd do that in the base class". I cringed, I protested, but they had their easy answer and he did it - and what a mess. This is a comment around code that didn't call the implementation in the base class.// sink can edit because it doesn't work for us here - fckn idiot //Inherited CanEdit(bEnabled);
D.0 -
-
I think my least favorite thing to hear in a job is the word "Agile". The moment I hear the words "We are an agile shop!" I know to expect nil documentation, no concept of architecture and unreasonable deadlines.
You should apply for this job:
http://www.irishjobs.ie/Jobs/Visual-C-C-Engineer-Dublin-6299664.aspx
0 -
-
Advertisement
-
-
Oh man, "agile" and "Visual C/C++" together in a job ad do not promote a sense of wellbeing.
Also, "Min 2 years recent experience in Net Technologies". What's that? .NET? Networking? Maintenance of fishing nets?
Also also, where do they get this "min 2 years recent experience of <random half-desired skill>" from? I wish people would stop saying things like that in job ads :rolleyes: Back when .NET was about 4 years old, I remember seeing an ad demanding "min 6 years experience of .NET technologies" or such. :mad:0 -
-
Just come across a database table which has 25 million rows and no keys.
The problem with asking questions in Ireland is that it is seen as a sign of weakness.
Depends on what question and how its asked, for example, in your case: 'Why wasn't a primary key implemented when this table was designed?' would be a reasonable question without showing weakness in my book.0 -
-
Advertisement
-
-
-
-
-
-
-
-
-
-
-
Advertisement
-
After a bit of googling, I remembered there were two that we used, along withIf you remember the name of it zynaps can you post it here? Sounds really good.- "Checkstyle" (and corresponding Eclipse plugin, sadly not updated since 2006)
- "Findbugs", seems more recently updated, but some of the website is down anyway :rolleyes:
In fact, both of these (as well as a Cobertura test coverage report) were generated automatically by Maven whenever we were thinking about checking in some changes to the SVN repo. Kind of amazing how powerful coding tools (especially free, open source ones!) have become in the last decade!
Needs a lot of horror to compensate for all that goodness...
[edit]
Actually I think we used a third (!) static code analyser, PMD for some reason... :P0 -
yeah we use all of those, PMD is quite good apart from it moaning about silly things like creating objects in loops or complaing about too many if statements. However if a project is run well and code reviewed and all PMD errors have to be ok'd to insert a NO PMD comment beforehand then it works out quite well.After a bit of googling, I remembered there were two that we used, along with- "Checkstyle" (and corresponding Eclipse plugin, sadly not updated since 2006)
- "Findbugs", seems more recently updated, but some of the website is down anyway :rolleyes:
In fact, both of these (as well as a Cobertura test coverage report) were generated automatically by Maven whenever we were thinking about checking in some changes to the SVN repo. Kind of amazing how powerful coding tools (especially free, open source ones!) have become in the last decade! Needs a lot of horror to compensate for all that goodness...
[edit]
Actually I think we used a third (!) static code analyser, PMD for some reason... :P
On the horror story, i cant believe people cant distinguish between unit tests and integration tests and the need for both. My current project has integration tests and unit tests all thrown into the one test directory, the integration tests require a huge db import( and no one knows now at this stage what data is in it ffs ) and its a pain to setup. No xml's for data just needed for 1 test and remove it afterwards, arrghhh lol0 -
-
-
-
-
I just had to share this one. I was working on an ecommerce site a couple of months back. The original coders charged an arm, a leg, and a good chunk of torso for this site, so you'd hope it'd be well coded. No such luck
It's a kind of specialist ecommerce site, can't say which, but you might be able to guess. When a customer views a product, they need to select from a list of basic options.
Now we needed to change this list of options, remove and simplify the list to tidy it up a bit, make the labels clearer to the end user what each one did for usability and conversion.
We removed a couple of the options, no problem, obviously we didn't change element id's. But when we changed the text titles on the form input elements, the whole page broke!
On investigating the problem, I discovered that the back end of the options code looked like as follows:if($_value->getTitle() == "None") { /* do stuff */ } else if($_value->getTitle() == "Basic Widget") { /* do stuff */ } else if($_value->getTitle() == "More Expensive Widget A" || $_value->getTitle() == "More Expensive Widget B") { /* do stuff */ } else if($_value->getTitle() == "Contact my specialist, I do not have XXXX") { /* do stuff */ } else if($_value->getTitle() == "I will fax a copy to +353 (0)123 4567890" || $_value->getTitle() == "You already have my details on file" || $_value->getTitle() == "I will scan and email a copy to <a href='mailto:info@12345672222domain.com'>info@12345672222domain.com</a>" || $_value->getTitle() == "I will fax a copy to 1890 123456") { /* do stuff */ } else if($_value->getTitle() == "I will be responsible for my details and i will input it below") { /* do stuff */ }
There are several ways to reference an input in HTML forms -> PHP, but hardcoding the title text in has got be one of the dumbest. In this case, if the company had changed their fax number, their ecommerce processing would break.
This site cost approximately a junior developer's entire annual salary. *boggle*0 -
-
-
Advertisement
-
Advertisement