Advertisement
Boards are fundraising to help the people of Ukraine via the Red Cross at this horrific time. Please donate and share if you can, you will find the link here. Many thanks.

DIY Desktop Site Customisation - Use at own risk

123468

Comments

  • Registered Users Posts: 2,935 ✭✭✭ smuggler.ie


    Could some one point right direction. Per image, post text body field only expand once text exceed hight of user "data" on the left. Would love to get it shrink to bare min

    Also reduce spacing above and bellow signature image

    CSS if posible please. Thanks




  • Registered Users Posts: 4,296 ✭✭✭ iLikeWaffles


    Actually just looking at that. One moment



  • Registered Users Posts: 4,296 ✭✭✭ iLikeWaffles


    /* user signiture padding top */
    .Content .MessageList .UserSignature {
      border-top: 1px solid rgb(211, 212, 213);
      padding-top: 5px;
      padding-bottom: 0px;
      margin-top: 0px;
      margin-bottom: 0px;
      clear: both;
    }
    
    /* margin bottom */
    .userContent.userContent.userContent.userContent .float-left .embedExternal-content, .UserContent.UserContent.UserContent.UserContent .float-left .embedExternal-content, .userContent.userContent.userContent.userContent .float-right .embedExternal-content, .UserContent.UserContent.UserContent.UserContent .float-right .embedExternal-content {
      margin-bottom: 2px;
    }
    


  • Registered Users Posts: 576 ✭✭✭ Captain Snow


    Deleted

    Post edited by Captain Snow on


  • Registered Users Posts: 14,962 ✭✭✭✭ fritzelly




  • Advertisement
  • Registered Users Posts: 2,935 ✭✭✭ smuggler.ie


    Thanks, squashed even further with { margin-bottom: -40px;} as react buttons are 30px. will see how it goes.

    now remaining post text body.

    PS.: could you convert your code into quote instead code block - potentially it causes this page freeze. Thanks



  • Registered Users Posts: 2,935 ✭✭✭ smuggler.ie




  • Registered Users Posts: 4,296 ✭✭✭ iLikeWaffles




  • Registered Users Posts: 4,296 ✭✭✭ iLikeWaffles


    a codeblock won't cause the page to freeze it is any formatting that causes the issue as far as I can tell.



  • Registered Users Posts: 2,935 ✭✭✭ smuggler.ie


    If you say so, i am not certain. i noticed its not bad in the morning -bad in the afternoon. However it effects this thread most. I could be wrong



  • Advertisement
  • Registered Users Posts: 17,664 ✭✭✭✭ Ads by Google


    What's the issue? Freezes?



  • Registered Users Posts: 2,935 ✭✭✭ smuggler.ie


    not right now, but last few evening was seriously bad, down to need to reload page in new tab or even restart FF.



  • Registered Users Posts: 4,296 ✭✭✭ iLikeWaffles



    Seems so, editing a post with formatting seemed to trigger it for me. Refreshing the page seemed to fix. It could have been site wide also. Reply box seems to freeze when a draft saves so if that is happening all at once site wide it might account for it?!



  • Registered Users Posts: 2,083 ✭✭✭ archfi


    Unfortunately, it does and specifically for a good few users on this thread and only this thread in my experience. Page 2 for instance is a huge inconvenience to even open, for me at least but I don't think I'm alone there.

    'In our rush to destigmatize the exception, we’ve stigmatized the rule.'

    --Benjamin Boyce



  • Registered Users Posts: 4,296 ✭✭✭ iLikeWaffles



    No issue with page 2 my end. Has to be something else causing the issue. I've tested both formatting and a codeblock on another thread and saw no issue there also. Which leads me to believe it might be drafts being saved or the accumulation of them in a users profile. I have no drafts but I also cleared my cache so could be a cache issue.



  • Registered Users Posts: 2,083 ✭✭✭ archfi


    It's odd alright.

    when I have a chance I'll test it out with a few browsers with/without extensions/addons - it may well be fingerprinting browser defences for instance.

    'In our rush to destigmatize the exception, we’ve stigmatized the rule.'

    --Benjamin Boyce



  • Registered Users Posts: 14,962 ✭✭✭✭ fritzelly


    It seems they have done some fixes on the backend - page 2 seems to be working fine for me now



  • Registered Users Posts: 17,664 ✭✭✭✭ Ads by Google


    I edited your code for thanks so it works for the opening post in a thread, Fritz.

      $(".ReactButton-Like").each(function () {
    
    
        var postid = $(this).closest("li").attr("id");
        /**
         * Fix opening post
         */
        if (postid == "Comment_") {
          postid = $(this).attr('href').split('=')[1];
          console.log(postid)
          $(this).closest("li").attr('id', "Comment_" + postid);
          $(this).closest("li").attr('req_type', "Discussion");
        } else {
          postid = postid.split("_");
          postid = postid[1];
        }
        $("<div class='fritzelly_thanks' id='thanks_" + postid + "'> </div>").insertAfter($(this).closest(".postbit-wrapper"));
    
    
      });
      $(".ReactButton-Like .Count").each(function () {
        var thanksTotal = $(this).text();
        postid = $(this).closest("li").attr("id")
        post_id = postid.split("_")
        post_id = post_id[1]
        /**
         * Check comment or discussion
         */
        var type = 'Comment';
        if ($(this).closest("li").attr('req_type') == "Discussion") {
          type = "Discussion";
        }
        $.ajax({
          url: "https://www.boards.ie/reactions/users/" + type + "/" + post_id + "/like?DeliveryType=VIEW",
          method: "GET",
          custom: post_id,
          thanksTotal: thanksTotal
        })
          .done(function (data, textStatus, jqXHR) {
            var postID = this.custom;
            $('#thanks_' + postID).append("Thanked by: ");
            var thanksArray = [];
            $(data).find('li a').each(function () {
              if ($(this).attr("title") != undefined) {
                thanksArray.push($(this).attr("title"));
              }
            });
            if (this.thanksTotal > 10) {
              thanksArray.push(' and ' + (thanksTotal - 10) + ' more.')
            }
            $('#thanks_' + postID).append(thanksArray.join(', '));
          });
      });
    


  • Registered Users Posts: 17,664 ✭✭✭✭ Ads by Google


    And I found dark mode for code blocks somewhere.

    .hljs {
       display: block !important;
       overflow-x: auto !important;
       padding: 1em !important;
       color: #dfdfe0 !important;
       background: #23232d !important;
       border: solid #393948 1px !important
    }
    
    
    .hljs-comment,
    .hljs-quote {
       color: #a5b0bd !important;
       font-style: italic !important
    }
    
    
    .hljs-doctag,
    .hljs-formula,
    .hljs-keyword {
       color: #ef81b0 !important
    }
    
    
    .hljs-deletion,
    .hljs-name,
    .hljs-section,
    .hljs-selector-tag,
    .hljs-subst {
       color: #dfdfe0 !important
    }
    
    
    .hljs-literal {
       color: #ef81b0 !important
    }
    
    
    .hljs-addition,
    .hljs-attribute,
    .hljs-meta-string,
    .hljs-regexp,
    .hljs-string {
       color: #f08875 !important
    }
    
    
    .hljs-built_in,
    .hljs-class .hljs-title {
       color: #dfdfe0 !important
    }
    
    
    .hljs-number {
       color: #d5ca86 !important
    }
    
    
    .hljs-attr,
    .hljs-selector-attr,
    .hljs-selector-class,
    .hljs-selector-pseudo,
    .hljs-template-variable,
    .hljs-type,
    .hljs-variable {
       color: #bbf0e4 !important
    }
    
    
    .hljs-bullet,
    .hljs-link,
    .hljs-meta,
    .hljs-selector-id,
    .hljs-symbol,
    .hljs-title {
       color: #dfdfe0 !important
    }
    
    
    .hljs-emphasis {
       font-style: italic !important
    }
    
    
    .hljs-strong {
       font-weight: 700 !important
    }
    
    
    .hljs-link {
       text-decoration: underline !important
    }
    


  • Registered Users Posts: 14,962 ✭✭✭✭ fritzelly



    Oh, how did you find that? Even the Thanks button itself is broken returning no thankers



  • Advertisement
  • Registered Users Posts: 14,962 ✭✭✭✭ fritzelly




  • Registered Users Posts: 2,935 ✭✭✭ smuggler.ie


    Don't know lads, came back after few hours at barbeque and found "this page has crashed" - reloaded and found few posts heavily populated with codeblock....Tell me its not the cause.



  • Registered Users Posts: 4,296 ✭✭✭ iLikeWaffles


    You all have custom code so it is likely that or as I said earlier a performance issue boards is having with drafts. The saving of a draft is the only freeze I see and that is site wide.



  • Registered Users Posts: 14,962 ✭✭✭✭ fritzelly


    I've tried it with no addons - this thread when there are codeblocks is the only one that hangs

    For some reason when there is a code block on the page it hangs the ajax calls


    So please all stop using the code block



  • Registered Users Posts: 4,296 ✭✭✭ iLikeWaffles


    Have you tried deleting your drafts and clearing your cache?



  • Registered Users Posts: 14,962 ✭✭✭✭ fritzelly



    I have no drafts and drafts shouldn't be an issue as they are local storage - it is only this thread and only this thread has codeblocks on it, when there is no codeblocks on the page then the page doesn't hang. As soon as you posted a code block it started freezing



  • Registered Users Posts: 4,296 ✭✭✭ iLikeWaffles


    What is it about codeblocks that would cause performance issues? Check next time you have a freeze does it happen when saving the draft?



  • Registered Users Posts: 14,962 ✭✭✭✭ fritzelly



    It's executing some ajax calls to the server (this may be part of the draft auto save code but they are stored locally and I can only see network activity) - I don't have the patience to track them down and go thru them. Its probably just some badly written JS that is firing off a routine that may have some shared code with the codeblock stuff



  • Registered Users Posts: 4,296 ✭✭✭ iLikeWaffles


    highlight.js seems to have an issue, it is a 3rd party addon for codeblocks that allows users to highlight the block of code v9 is likely being used, v10 doesn't seem to cause the issue.

    https://github.com/laurent22/joplin/issues/3281#issuecomment-634793044



  • Advertisement
  • Registered Users Posts: 14,962 ✭✭✭✭ fritzelly



    Great detective work - the highlighting was my prime suspect



Advertisement