DIY Desktop Site Customisation - Use at own risk

smuggler.ie · 25-07-2021 03:41PM

Could some one point right direction. Per image, post text body field only expand once text exceed hight of user "data" on the left. Would love to get it shrink to bare min

Also reduce spacing above and bellow signature image

CSS if posible please. Thanks

iLikeWaffles · 25-07-2021 03:50PM

Actually just looking at that. One moment

iLikeWaffles · 25-07-2021 03:54PM

/* user signiture padding top */
.Content .MessageList .UserSignature {
  border-top: 1px solid rgb(211, 212, 213);
  padding-top: 5px;
  padding-bottom: 0px;
  margin-top: 0px;
  margin-bottom: 0px;
  clear: both;
}

/* margin bottom */
.userContent.userContent.userContent.userContent .float-left .embedExternal-content, .UserContent.UserContent.UserContent.UserContent .float-left .embedExternal-content, .userContent.userContent.userContent.userContent .float-right .embedExternal-content, .UserContent.UserContent.UserContent.UserContent .float-right .embedExternal-content {
  margin-bottom: 2px;
}

Captain Snow · 25-07-2021 03:59PM

Deleted

fritzelly · 25-07-2021 04:05PM

https://www.boards.ie/discussion/comment/117659573#Comment_117659573

Wrong thread

smuggler.ie · 25-07-2021 04:15PM

https://www.boards.ie/discussion/comment/117659540#Comment_117659540

Thanks, squashed even further with { margin-bottom: -40px;} as react buttons are 30px. will see how it goes.

now remaining post text body.

PS.: could you convert your code into quote instead code block - potentially it causes this page freeze. Thanks

smuggler.ie · 25-07-2021 04:18PM

https://www.boards.ie/discussion/comment/117659477#Comment_117659477

Needed a lot , thanks

iLikeWaffles · 25-07-2021 04:22PM

https://www.boards.ie/discussion/comment/117659594#Comment_117659594

test

iLikeWaffles · 25-07-2021 04:28PM

https://www.boards.ie/discussion/comment/117659622#Comment_117659622

a codeblock won't cause the page to freeze it is any formatting that causes the issue as far as I can tell.

smuggler.ie · 25-07-2021 04:30PM

https://www.boards.ie/discussion/comment/117659675#Comment_117659675

If you say so, i am not certain. i noticed its not bad in the morning -bad in the afternoon. However it effects this thread most. I could be wrong

25-07-2021 04:30PM

What's the issue? Freezes?

smuggler.ie · 25-07-2021 04:32PM

not right now, but last few evening was seriously bad, down to need to reload page in new tab or even restart FF.

iLikeWaffles · 25-07-2021 04:39PM

https://www.boards.ie/discussion/comment/117659692#Comment_117659692

Seems so, editing a post with formatting seemed to trigger it for me. Refreshing the page seemed to fix. It could have been site wide also. Reply box seems to freeze when a draft saves so if that is happening all at once site wide it might account for it?!

archfi · 25-07-2021 04:52PM

https://www.boards.ie/discussion/comment/117659675#Comment_117659675

Unfortunately, it does and specifically for a good few users on this thread and only this thread in my experience. Page 2 for instance is a huge inconvenience to even open, for me at least but I don't think I'm alone there.

iLikeWaffles · 25-07-2021 04:56PM

https://www.boards.ie/discussion/comment/117659775#Comment_117659775

No issue with page 2 my end. Has to be something else causing the issue. I've tested both formatting and a codeblock on another thread and saw no issue there also. Which leads me to believe it might be drafts being saved or the accumulation of them in a users profile. I have no drafts but I also cleared my cache so could be a cache issue.

archfi · 25-07-2021 05:20PM

https://www.boards.ie/discussion/comment/117659790#Comment_117659790

It's odd alright.

when I have a chance I'll test it out with a few browsers with/without extensions/addons - it may well be fingerprinting browser defences for instance.

fritzelly · 25-07-2021 05:33PM

It seems they have done some fixes on the backend - page 2 seems to be working fine for me now

25-07-2021 05:47PM

I edited your code for thanks so it works for the opening post in a thread, Fritz.

  $(".ReactButton-Like").each(function () {


    var postid = $(this).closest("li").attr("id");
    /**
     * Fix opening post
     */
    if (postid == "Comment_") {
      postid = $(this).attr('href').split('=')[1];
      console.log(postid)
      $(this).closest("li").attr('id', "Comment_" + postid);
      $(this).closest("li").attr('req_type', "Discussion");
    } else {
      postid = postid.split("_");
      postid = postid[1];
    }
    $("<div class='fritzelly_thanks' id='thanks_" + postid + "'> </div>").insertAfter($(this).closest(".postbit-wrapper"));


  });
  $(".ReactButton-Like .Count").each(function () {
    var thanksTotal = $(this).text();
    postid = $(this).closest("li").attr("id")
    post_id = postid.split("_")
    post_id = post_id[1]
    /**
     * Check comment or discussion
     */
    var type = 'Comment';
    if ($(this).closest("li").attr('req_type') == "Discussion") {
      type = "Discussion";
    }
    $.ajax({
      url: "https://www.boards.ie/reactions/users/" + type + "/" + post_id + "/like?DeliveryType=VIEW",
      method: "GET",
      custom: post_id,
      thanksTotal: thanksTotal
    })
      .done(function (data, textStatus, jqXHR) {
        var postID = this.custom;
        $('#thanks_' + postID).append("Thanked by: ");
        var thanksArray = [];
        $(data).find('li a').each(function () {
          if ($(this).attr("title") != undefined) {
            thanksArray.push($(this).attr("title"));
          }
        });
        if (this.thanksTotal > 10) {
          thanksArray.push(' and ' + (thanksTotal - 10) + ' more.')
        }
        $('#thanks_' + postID).append(thanksArray.join(', '));
      });
  });

25-07-2021 05:51PM

And I found dark mode for code blocks somewhere.

.hljs {
   display: block !important;
   overflow-x: auto !important;
   padding: 1em !important;
   color: #dfdfe0 !important;
   background: #23232d !important;
   border: solid #393948 1px !important
}


.hljs-comment,
.hljs-quote {
   color: #a5b0bd !important;
   font-style: italic !important
}


.hljs-doctag,
.hljs-formula,
.hljs-keyword {
   color: #ef81b0 !important
}


.hljs-deletion,
.hljs-name,
.hljs-section,
.hljs-selector-tag,
.hljs-subst {
   color: #dfdfe0 !important
}


.hljs-literal {
   color: #ef81b0 !important
}


.hljs-addition,
.hljs-attribute,
.hljs-meta-string,
.hljs-regexp,
.hljs-string {
   color: #f08875 !important
}


.hljs-built_in,
.hljs-class .hljs-title {
   color: #dfdfe0 !important
}


.hljs-number {
   color: #d5ca86 !important
}


.hljs-attr,
.hljs-selector-attr,
.hljs-selector-class,
.hljs-selector-pseudo,
.hljs-template-variable,
.hljs-type,
.hljs-variable {
   color: #bbf0e4 !important
}


.hljs-bullet,
.hljs-link,
.hljs-meta,
.hljs-selector-id,
.hljs-symbol,
.hljs-title {
   color: #dfdfe0 !important
}


.hljs-emphasis {
   font-style: italic !important
}


.hljs-strong {
   font-weight: 700 !important
}


.hljs-link {
   text-decoration: underline !important
}

fritzelly · 25-07-2021 06:01PM

https://www.boards.ie/discussion/comment/117659979#Comment_117659979

Oh, how did you find that? Even the Thanks button itself is broken returning no thankers

fritzelly · 25-07-2021 06:02PM

https://www.boards.ie/discussion/comment/117659995#Comment_117659995

That looks very nice

Page is freezing again

smuggler.ie · 25-07-2021 10:30PM

Don't know lads, came back after few hours at barbeque and found "this page has crashed" - reloaded and found few posts heavily populated with codeblock....Tell me its not the cause.

iLikeWaffles · 25-07-2021 11:26PM

You all have custom code so it is likely that or as I said earlier a performance issue boards is having with drafts. The saving of a draft is the only freeze I see and that is site wide.

fritzelly · 25-07-2021 11:54PM

https://www.boards.ie/discussion/comment/117661085#Comment_117661085

I've tried it with no addons - this thread when there are codeblocks is the only one that hangs

For some reason when there is a code block on the page it hangs the ajax calls

So please all stop using the code block

iLikeWaffles · 26-07-2021 12:00AM

https://www.boards.ie/discussion/comment/117661152#Comment_117661152

Have you tried deleting your drafts and clearing your cache?

fritzelly · 26-07-2021 12:02AM

https://www.boards.ie/discussion/comment/117661166#Comment_117661166

I have no drafts and drafts shouldn't be an issue as they are local storage - it is only this thread and only this thread has codeblocks on it, when there is no codeblocks on the page then the page doesn't hang. As soon as you posted a code block it started freezing

iLikeWaffles · 26-07-2021 12:06AM

https://www.boards.ie/discussion/comment/117661170#Comment_117661170

What is it about codeblocks that would cause performance issues? Check next time you have a freeze does it happen when saving the draft?

fritzelly · 26-07-2021 12:13AM

https://www.boards.ie/discussion/comment/117661181#Comment_117661181

It's executing some ajax calls to the server (this may be part of the draft auto save code but they are stored locally and I can only see network activity) - I don't have the patience to track them down and go thru them. Its probably just some badly written JS that is firing off a routine that may have some shared code with the codeblock stuff

iLikeWaffles · 26-07-2021 12:41AM

https://www.boards.ie/discussion/comment/117661200#Comment_117661200

highlight.js seems to have an issue, it is a 3rd party addon for codeblocks that allows users to highlight the block of code v9 is likely being used, v10 doesn't seem to cause the issue.

https://github.com/laurent22/joplin/issues/3281#issuecomment-634793044

fritzelly · 26-07-2021 12:46AM

https://www.boards.ie/discussion/comment/117661258#Comment_117661258

Great detective work - the highlighting was my prime suspect

DIY Desktop Site Customisation - Use at own risk

Comments

Welcome!