C#

awec

Sephiroth_dude wrote: »

Would you mind showing me an example of what you mean?

If the first book in your collection doesn't meet your search criteria, the function will return false, and therefore won't check any subsequent books.

Earthhorse

Sephiroth_dude wrote: »

Would you mind showing me an example of what you mean?

What he means is:

public Boolean CheckIfBookExists(string name,string title)
{
     bool bookExists = false;
     foreach(Library lib in library)
     ...
}

Then use that bool as your return value. I won't write the entire function for you because you should really do it yourself so you internalise it.

If you can't understand why your existing for loop, or indeed any subsequent ones you write, isn't working as expected I strongly encourage you to use the debugger and step through each line of code to see what's happening. Visual Studio has really great runtime debugging tools and you should use them.

rock22

Sephiroth_dude wrote: »

Would you mind showing me an example of what you mean?

Sorry , didn't see your post but both Awec and Earthhorse have explained what I meant.

You should try to complete the code Earthhorse provided.

awec

This is the most optimum fix if you want to keep using linear search. No point in continuing to enumerate once you find what you're looking for.

public Boolean CheckIfBookExists(string name,string title)
        {
            foreach(Library lib in library)
            {
                if(lib.AuthorName.Equals(name) && lib.BookName.Equals(title))
                {
                    return true;
                }
                [S]else
                {
                    return false;
                }[/S]
            }
            return [S]true[/S] false;
        }

Linear search is not a great approach to take if your collection can be large, there are much more performant approaches. If you think about it practically, if you were searching for a specific book in a library you wouldn't start at one end of the room and go book-by-book to the other end to try find it.

shootermacg

You don't really even need a method:

return Library.Any(lib =>
lib.AuthorName.Equals(name) && lib.BookName.Equals(title));

Earthhorse

awec wrote: »

This is the most optimum fix if you want to keep using linear search.

Most optimum is not the most optimum way to say optimum.

Anyway, the most optimum fix is to fix the coder, not the code.

:cool::cool::cool::cool::cool::cool::cool::cool::cool::cool::cool: