PHP, Loop, Check Boxes

bob2oo7

Hi guys

I would be greatfull with some help please

I run an sql query, then in a while loop I ouput and create a table with one column of check boxes

I then have a javascript function that I need to select all the checkboxes or uncheck them

This funcation works if I only return one row in my while look, but any more than one row and the "select all" doesnt select anything

I would be ever so greatfull for any help

Here is the code:

Javascript:

<script type="text/javascript">
<!--
function checkall()
{
var df=document.InboxForm.elements;
for(var i=0;i<df.length;i++)
{
//alert(df.name);
df.checked=true;
}
}

function uncheckall()
{
var df=document.InboxForm.elements;
for(var i=0;i<df.length;i++)
{
//alert(df.name);
df.checked=false;
}
}
-->
</script>


While loop:

while($row = mysql_fetch_array($result))
{
$subject=$row;
$datesent=$row;
$fromuser=$row;
$from_firstname=$row;
$from_lastname=$row;
$id=$row;
$read=$row;

echo'





<tr '.$RowColor.'>
<td align="center"><form name="InboxForm"><input type="checkbox" name ="selected[]"></form></td>

<td align="center" style="font-weight: '.$new.'; color:'.$new_color.';">'.$from_firstname.' '.$from_lastname.' ('.$fromuser.')</td>


<td style="word-wrap: break-word; font-weight: '.$new.'; color:'.$new_color.';" align="center">'.$subject.'</td>
<td align="center" style="font-weight: '.$new.'; color:'.$new_color.'";>'.$datesent.'</td>

<td align="center" style="font-weight: '.$new.'; color:'.$new_color.';"><a href="view-message.php?id='.$id.'"><img src="images/view-message.png"></a></td></tr>';

}


Then call the function to check all the check boxes:

echo '
<a href="#" onclick="checkall(InboxForm);" title="Check all boxes">CheckAll</a>';



Thanks in advance of any replies

Liam Byrne

Firstly, did you alert the length that it's getting ?

Then try giving each checkbox a unique ID - leaving the NAME as is

Failing that, use jQuery - it'll do this with its eyes closed using one line of code.

bob2oo7

Sorted with Jquery, thank you for the help