Advertisement
Help Keep Boards Alive. Support us by going ad free today. See here: https://subscriptions.boards.ie/.
If we do not hit our goal we will be forced to close the site.

Current status: https://keepboardsalive.com/

Annual subs are best for most impact. If you are still undecided on going Ad Free - you can also donate using the Paypal Donate option. All contribution helps. Thank you.
https://www.boards.ie/group/1878-subscribers-forum

Private Group for paid up members of Boards.ie. Join the club.
Hi all, please see this major site announcement: https://www.boards.ie/discussion/2058427594/boards-ie-2026

Getting a code review?

  • 26-04-2014 02:38AM
    #1
    Fenster
    Closed Accounts Posts: 4,763 ✭✭✭


    Is there any better way to get one than to link my project somewhere and tout its superiority? :p

    Less facetiously, if anyone would like to dress me down about my latest project, you can find the link below. Simple HTML/CSS theme, with some jQuery interactivity (gallery/lightbox):

    https://github.com/bhalash/Funcan

    Live version:

    http://peppermint.bhalash.com/funcan/gallery.html


Comments

  • #2
    Talisman
    Registered Users, Registered Users 2 Posts: 7,208 ✭✭✭Talisman


    Just had a quick look on Github - your JS code is well commented, well done I rarely have the patience.

    One thing I noticed in your HTML is that you are using the time element but you're not specifying the time in a machine readable format.
    <time class="post-date">Tuesday September 15, 2009</time>

    In this case there should be a datetime attribute:
    <time class="post-date" datetime="2009-09-15">Tuesday September 15, 2009</time>


  • #3
    Fenster
    Closed Accounts Posts: 4,763 ✭✭✭Fenster


    Well spotted, and fixed.


Advertisement