Advertisement
Help Keep Boards Alive. Support us by going ad free today. See here: https://subscriptions.boards.ie/.
If we do not hit our goal we will be forced to close the site.

Current status: https://keepboardsalive.com/

Annual subs are best for most impact. If you are still undecided on going Ad Free - you can also donate using the Paypal Donate option. All contribution helps. Thank you.
https://www.boards.ie/group/1878-subscribers-forum

Private Group for paid up members of Boards.ie. Join the club.
Hi all, please see this major site announcement: https://www.boards.ie/discussion/2058427594/boards-ie-2026

Wrapping existing function in wrapper?

  • 22-04-2014 01:06AM
    #1
    Fenster
    Closed Accounts Posts: 4,763 ✭✭✭


    Another style question. I resize images at several points in a script, and in each case I use an identical built-in function to shrink or grow the images. I chose to wrap this existing function in one of my own in case I needed to change it in future, which I haven't to this point.

    Is this a good or bad practice?


Comments

  • #2
    Colonel Panic
    Registered Users, Registered Users 2 Posts: 2,062 ✭✭✭Colonel Panic


    "You ain't gonna need it". If you need to change the function later, change it later.


  • #3
    PrzemoF
    Registered Users, Registered Users 2 Posts: 1,929 ✭✭✭PrzemoF


    I'd get rid of it unless it makes calling the wrapped function easier/cleaner (i.e fixed parameters) or extends original features (i.e. fixed aspect ratio or scale width given height + aspect ratio). Keeping code just because you might need it in the future is wrong. Remove the code, give the commit a good description (you use a SCM, do you?) and if you'll ever need it it will be waiting for you without cluttering the current version of your code.


  • #4
    Fenster
    Closed Accounts Posts: 4,763 ✭✭✭Fenster


    Cheers!


Advertisement