C programming, loop bugs

TM69 · 26-03-2014 11:17PM #1

This is the code i'm having a problem with, the code is supposed to read in the numbers and print them out in ascending order, it compiles but the output is all wrong, any help would be great.

int winning_nums [] = { 1, 3 , 5 , 7, 9, 11, 42} ;

int nums[NUMBERS];
int i, temp, j;
int highest, lowest;

printf("enter 6 numbers of your choice up to and including 42 \n");

for(i=0;i<NUMBERS;i++)
{
scanf("%d", &nums);
flushall();
}

for (i = 0; i < NUMBERS - 1; i++)
{
for (j = 0; j < NUMBERS-i-1; j++)
{
if ( nums[j] > nums[j+1] )
{
temp = nums[j];
nums[j] = nums[j+1];
nums[j+1] = temp;
}
}
}

printf("numbers you entered are %d \n");
for(i=0;i<NUMBERS;i++)
{
printf("%d", &nums);
flushall();
}

maki · 27-03-2014 12:43AM

Your final printf statement should be:
printf("%d", nums);

Using an ampersand (like &nums) returns the address of the value, not the value itself.

Tokyo · 27-03-2014 01:06AM

Just ran it, using the same sort routine that you are using, and it runs fine. Something else in your code breaking it perhaps?

[edit]...or you could just take the answer from ^^^

#include <stdio.h>
#define NUMBERS 6

int main(void) {

	int nums[NUMBERS] = { 14, 3 , 35 , 27, 11, 42} ;;
	int i, temp, j;
	int highest, lowest;
	
	//Sort Loop
	for (i = 0; i < NUMBERS-1; i++)
	{
		for (j = 0; j < NUMBERS-i-1; j++)
		{
			if ( nums[j] > nums[j+1] )
			{
				temp = nums[j];
				nums[j] = nums[j+1];
				nums[j+1] = temp;
			}
		}
	}

	printf("numbers you entered are \n");
	for(i=0;i<NUMBERS;i++)
	{
		printf("%d \n", nums[i]);
	} 

	return 0;
}

PrzemoF · 27-03-2014 11:49AM

OP, read this one:
http://pweb.netcom.com/~tjensen/ptr/pointers.htm
[pdf] http://home.earthlink.net/~momotuk/pointers.pdf

That will save you a lot of time in long run.

yoyo · 27-03-2014 04:11PM

Moved from Comp & Tech.

Greenmachine · 27-03-2014 04:15PM

PrzemoF wrote: »

OP, read this one:
http://pweb.netcom.com/~tjensen/ptr/pointers.htm
[pdf] http://home.earthlink.net/~momotuk/pointers.pdf

That will save you a lot of time in long run.

Some helpful links there.

C programming, loop bugs

Comments