For...each loop problem

frezzabelle wrote: »

That's an iteration for a List. You need to iterate the map using the keys
E.g.

public static void printMap(Map mp) {
* * Iterator it = mp.entrySet().iterator();
* * while (it.hasNext()) {
* * * * Map.Entry pairs = (Map.Entry)it.next();
* * * * System.out.println(pairs.getKey() + " = " + pairs.getValue());
* * }
}
Maybe check the status while in each iteration?

selfdiy wrote: »

A bit of a stab in the dark here, but would the following work.

/**
* Displays the number of houses that are sold.
*/
public void displaySoldHouses()
{
int count = 0;
for(Property property : properties.values){
       if (property instanceof House){
             House house = (HOUSE) property;
             if(house.isSold()){
                  count++; 
             }
       }
}

/**
     * Displays the total number of houses which have been sold.
     */
    public void displayHousesSold()
    {
       int count = 0;
       if (!properties.isEmpty()) {
           Set <String> keys = properties.keySet();
           for (String id : keys) {
               if (properties.get(id).isSold()) {
                count = count + 1;
            }
            else {
                System.out.println("There are no houses sold");
            }
          }
           System.out.println("The number of sold houses are: " + count);        
        }
        else {
            System.out.println("There are no properties in the HashMap!");
        }
    }

selfdiy wrote: »

If you could post your Property and House class.
I should be able to whip up an example....

public class Property implements Serializable
{
    private String propertyId;
    private String address;
    private int numberOfBedrooms;
    protected double sellingPrice;
    private boolean sold;
    private Buyer buyer;
    protected static double stampDuty = 0.20;
   
    /**
     * Constructor for objects of class Property
     */
    public Property(String propertyId, String address, int numberOfBedrooms, double sellingPrice)
    {
        if (propertyId == " ") {
            System.out.println("A property's ID can't be blank");
        }
        else {
            this.propertyId = propertyId;
            this.address = address;
            this.numberOfBedrooms = numberOfBedrooms;
            this.sellingPrice = sellingPrice;
        }
    }
    /**
     * Gets the property's id.
     */
    public String getId()
    {
        return propertyId;
    }
    
    /**
     * Gets the address of the property.
     */
    public String getAddress()
    {
        return address;
    }
    
    /**
     * Gets the number of bedrooms that the house has.
     */
    public int getNumberOfBedrooms()
    {
        return numberOfBedrooms;
    }
       
    /**
     * Gets the selling price of the property.
     */
    public double getSellingPrice()
    {
        return sellingPrice;
    }
    
    /**
     * Shows the buyer of a property, if there is one.
     */
    public Buyer getBuyer()
    {
        if (buyer != null) {
            return buyer;
        }
        return null;
    }
    
    /**
     * Calculates the price for a property.
     */
    public double calculatePrice()
    {
        sellingPrice = sellingPrice + (sellingPrice * stampDuty);
        return sellingPrice;
    }
    
    /**
     * Changes the selling price of the house.
     */
    public void changeSellingPrice(double sellingPrice)
    {
        this.sellingPrice = sellingPrice;
    }
    
    /**
     * Assigns a property to a buyer (sold).
     */
    public void setSold(boolean sold)
    {
        this.sold = true;
    }
       
    /**
     * Checks to see if the property is sold or not.
     */
    public boolean isSold()
    {
      return sold;
    } 
    
    /**
     * Sells a property - house or apartment.
     */
    public void sellProperty(Buyer buyer)
    {
      NumberFormat cf = NumberFormat.getCurrencyInstance();
        if (buyer != null) {
          if (buyer.getAmountOfMoney() > calculatePrice()) {
            setSold(true);
            this.buyer = buyer;
            System.out.println("The full cost of the property was " + cf.format(calculatePrice()));
         }
        else {
            System.out.println("The buyer can't afford to buy that property");
            System.out.println("The total cost of this property is: " + cf.format(calculatePrice()));
            System.out.println("The buyer's funds are: " + buyer.getAmountOfMoney());
         }
      }
      else {
          System.out.println("No buyer object was found");
        }
    }   
    
    /**
     * Returns a String of the details of the property and buyer.
     */
    public String toString()
    {
        NumberFormat cf = NumberFormat.getCurrencyInstance();
        String returnString = "";
        returnString = returnString + "\nProperty Id: " + propertyId + " ";
        returnString = returnString + "\nProperty Address: " + address + " ";
        returnString = returnString + "\nNumber of Bedrooms: " + numberOfBedrooms + " ";
        returnString = returnString + "\nSelling Price: " + cf.format(sellingPrice) + " ";
        if (sold) {
            returnString = returnString + "\nThe buyer's details are: ";
            returnString = returnString + buyer.toString();
        }
        else {
            returnString = returnString + "\nThis property has not been sold";
        }
        return returnString;
    }

public class House extends Property
{
   
    /**
     * Constructor for objects of class House
     */
    public House(String propertyId, String address, int numberOfBedrooms, double sellingPrice)
    {
       super(propertyId, address, numberOfBedrooms, sellingPrice); 
    }
     /**
     * Returns a String of the details of a house.
     */
    public String toString()
    {
        NumberFormat cf = NumberFormat.getCurrencyInstance();
        String returnString = super.toString();
        return returnString;
    }
    
}

tehjimmeh wrote: »

I haven't read the thread much, but why not:

/**
     * Displays the total number of houses which have been sold.
     */
    public void displayHousesSold()
    {
       int count = 0;
       if (!properties.isEmpty()) {
           Set <String> keys = properties.keySet();
           for (String id : keys) {
               Property p = properties.get(id);
               if ((p instanceof House ) && p.isSold()) {
                  count = count + 1;
            }
            else {
                System.out.println("There are no houses sold");
            }
          }
           System.out.println("The number of sold houses are: " + count);        
        }
        else {
            System.out.println("There are no properties in the HashMap!");
        }
    }

Seifer wrote: »

Neither "property" nor "properties" are keywords in Java.

http://download.oracle.com/javase/tutorial/java/nutsandbolts/_keywords.html

Java EE