What have I done wrong with this statement ?

Slaanesh · 26-11-2000 08:01PM #1

if( number1 &gt; (number2 & number3))
			largest = number1;
		
		if( number2 &gt; (number1 & number3))
			largest = number2;
		
		if( number3 &gt; (number1 & number2))
			largest = number3;

Enygma · 26-11-2000 08:35PM

Try this:

if ((number1 &gt; number2) && (number1 &gt; number3))
   largest = number1;

if ((number2 &gt; number1) && (number2 &gt; number3))
   largest = number2;

if ((number3 &gt; number1) && (number3 &gt; number2))
   largest = number3;

But there's a better way to get the largest number.....work it out

[This message has been edited by Enygma (edited 26-11-2000).]

satchmo · 26-11-2000 08:53PM

Slaanesh, the problem is in your comparison statements. Even though you might think
number1 > (number2 & number3)
sees if 'number1 is greater than number2 and number3', this isn't how it works - you can't translate it literally.
What that statement actually does it compares number1 to the bitwise AND of number2 and number3. When doing comparisons you have to do a comparison for every variable, as Enygma has shown you. However when you have a list of say, 100 numbers to compare, this method obviously becomes unfeasible and then a for-loop is probably your best bet.

Gerry · 28-11-2000 01:28AM

Have they not shown you loops yet over in blanch? That was the first thing we learned.
Unless you are just looking for the max of 2 numbers, your method is going to be longer and annoying. It would go something like:

void main(void)
{
int array[10] = {1,2,3,4,5,6,7,8,9,10};
int largest=0;
largest=array[0];
for(int i = 1;i<sizeOfArray; i++)
{
if array>largest;
largest=array;
}
}

What have I done wrong with this statement ?

Comments