php constant issue

ConsultClifford · 03-07-2004 10:15AM #1

hi i have two files

File A calls File B passing through the image parameter

onclick="window.open('viewimage.php?image=G6'

File B displays the image

<IMG height=172 src=<?=IMGS?>/<?php echo $_GET; ?>.jpg >

thats working fine so MY PROBLEM is:

in file B i have included a file which contains the image title constants
<? include_once ("english.inc") ?>
what i want to do is take the image parameter and from that select the right constant (which is named the same as the image)and display it on the page
define ('G6',"xxxxxxxxxxxxxxxxxxxxx"); is in english.inc

how do i do that ? because all i can do is echo "G6"??

RobertFoster · 03-07-2004 02:19PM

have you put <?php ?> tags in the inc file as it'll just read it in as text/html otherwise.

The Corinthian · 03-07-2004 10:45PM

I wouldn't store the image names in constants. However, if you do, retrieving them can be done by treating the constant as code to be executed rather than a string variable, using the eval function:
[PHP]
<IMG height="172" src="<? eval($_GET); ?>.jpg">
[/PHP]
As you can imagine this is highly inadvisable as it is an initiation to a code injection attack. You should store the names as an array instead.

ConsultClifford · 04-07-2004 08:45PM

tnx The Corinthian ill try that - should do it.

php constant issue

Comments