BUG - Brackets around links

mrcheez

Whenever I post and include a link in brackets, the last bracket gets appended to the end of the hyperlink, which ends up breaking the link.

e.g. I posted "... check out this page (http://www.mysite.com/MyPage)..."

and this ends up as a link to "http://www.mysite.com/MyPage)" when it should be "http://www.mysite.com/MyPage"


You can see an example in the first post in this thread:
http://www.boards.ie/vbulletin/showthread.php?t=2057606804

The link to the page on Tec7.ie is broken because of this bug.


EDIT: Actually the sample link I posted above to mysite.com also shows the error in action.

TherapyBoy

Why put the link in brackets at all? Is Boards doing this automatically?

[noparse](http://tec7.ie/product/trans7-clear-sealant/)[/noparse]

Looking at the link you posted above, one bracket is outside the link & one is inside. A quick text edit before you post would avoid this problem temporarily if the site is doing it automatically.

Spear

(http://tec7.ie/product/trans7-clear-sealant/)

A quick test shows that it is putting the bracket inside the tags. Presumably simply because the tags match from http:// onwards, and simply regard the ending ) as part of the URL.

mrcheez

Spear wrote: »

(http://tec7.ie/product/trans7-clear-sealant/)

A quick test shows that it is putting the bracket inside the tags. Presumably simply because the tags match from http:// onwards, and simply regard the ending ) as part of the URL.

Pretty much. I've noticed this issue for a few years amongst a lot of users (prompting many a "FYP" follow-up post)

Perhaps a quick fix is to remove all "(" or ")" in between tags as parentheses would not generally be used in urls?

Or encode them.

mrcheez

TherapyBoy wrote: »

A quick text edit before you post would avoid this problem temporarily if the site is doing it automatically.

Yes it's doing it automatically.

A quick text edit AFTER posting fixes the problem, but you have to remember to do this. Why not fix the problem at source rather than having to re-edit a post?

TherapyBoy

If you preview the post before you submit it, does it show up then? I've never encountered this problem when posting links so I'm genuinely interested in what's happening.

Spear

TherapyBoy wrote: »

If you preview the post before you submit it, does it show up then? I've never encountered this problem when posting links so I'm genuinely interested in what's happening.

It did in my case, using the old (superior) white skin.

I'm not sure how practical this would be to fix. It'd need a lot of sanity check/preprocessing to be done on links in an attempt to decide whether the bracket was intended or not. And given the scarcity of devs, who've been MIA for several years now, it seems unlikely to happen.

TherapyBoy

http://tec7.ie/product/trans7-clear-sealant/

http://tec7.ie/product/trans7-clear-sealant/

I can't reproduce the brackets appearing.

I'm following the link from the OP, removing the bracket & reloading the page so it appears correctly. Then copying the link from the address bar & pasting it into the text box, directly & through the hyperlink pop-up. I get the above. What am I doing wrong?

I'm still on the old white (superior) skin too. Viva la revolution!

Spear

TherapyBoy wrote: »

http://tec7.ie/product/trans7-clear-sealant/

http://tec7.ie/product/trans7-clear-sealant/

I can't reproduce the brackets appearing.

I'm following the link from the OP, removing the bracket & reloading the page so it appears correctly. Then copying the link from the address bar & pasting it into the text box, directly & through the hyperlink pop-up. I get the above. What am I doing wrong?

I'm still on the old white (superior) skin too. Viva la revolution!

(http://tec7.ie/product/trans7-clear-sealant/)

[noparse](http://tec7.ie/product/trans7-clear-sealant/)[/noparse]

Still does it for me. Maybe the editor mode plays a part.

mrcheez

Here's a test in "Quick Reply" mode...

My link (http://www.mylink.com/testpage/) is great




EDIT AFTER: yep seems to happen in "Quick Reply" mode too.

I never preview a post before posting... in fact this isn't an option in "Post Quick Reply"