disabled toggleButton changing state until ready? [android]

Tar.Aldarion

I have a toggle button that I press, keyboard keys are then pressed at half second delays. To stop a user pressing the button twice in quick succession and messing this up I disable the button while the commands are running, and enable it again after. This is a lot of messing about on the UI thread with repeated code. What would be a better way of doing this? Queue up all the commands in a thread or something and leave the user being able to press the button as much as they want? Or jsut abstract this runonui functionality to it's own method. Something else?

public void pushtotalk(final View view) {

       final boolean on = ((ToggleButton) view).isChecked();

        new Thread(new Runnable() {         
            @Override
            public void run() {
                try {
                    Instrumentation inst = new Instrumentation();
                    if (on)
                        {

                        runOnUiThread(new Runnable() {
                             public void run() {

                                 ((ToggleButton) view).setEnabled(false);


                            }
                        });



                 inst.sendKeyDownUpSync(KeyEvent.KEYCODE_NUMPAD_MULTIPLY);
                 Thread.sleep(500);
                 inst.sendKeyDownUpSync(KeyEvent.KEYCODE_9); 
                 Thread.sleep(500);

                          runOnUiThread(new Runnable() {
                                 public void run() {

                                     ((ToggleButton) view).setEnabled(true);


                                }
                            });


                        }
                    else
                        {   
                        runOnUiThread(new Runnable() {
                             public void run() {

                                 ((ToggleButton) view).setEnabled(false);


                            }


});
                inst.sendKeyDownUpSync(KeyEvent.KEYCODE_POUND);
                Thread.sleep(500);
                inst.sendKeyDownUpSync(KeyEvent.KEYCODE_9); 
                Thread.sleep(500);  
                runOnUiThread(new Runnable() {

                             public void run() {

                                 ((ToggleButton) view).setEnabled(true);


                            }
                        });
                    }

               }
                catch(InterruptedException e){
                    Log.d(TAG, "Failed to send keycodes: " + e.getMessage());
            }
        }   
    }).start();

}

onemorechance

What about enabling and disabling the button outside of the new thread?

As soon as you check to see if it's checked or not, can't you disable it then, before you start a new thread?

Tar.Aldarion

Heya that's good, I can indeed disable it beforehand, I had tried that and tried enabling at the end of the method but that happens instantly (as it's not attached to the thread delays) so I thought it wasn't working initially. I suppose I can disable the button beforehand and reenable it in the thread to remove some of the duplication.

Or else add a delay when reenabling the button at the end of the thread by calling a handler but that's more code again.
Guess removing some of the duplication will do unless there is some way to introduce delays without threads/handers! Thanks.

public void pushtotalk(final View view) {

		final boolean on = ((ToggleButton) view).isChecked();
		[B]((ToggleButton) view).setEnabled(false);[/B]

		new Thread(new Runnable() {
			@Override
			public void run() {
				try {
					Instrumentation inst = new Instrumentation();
					if (on) {
						inst.sendKeyDownUpSync(KeyEvent.KEYCODE_NUMPAD_MULTIPLY);
						Thread.sleep(500);
						inst.sendKeyDownUpSync(KeyEvent.KEYCODE_9);
						Thread.sleep(500);

					[B]	runOnUiThread(new Runnable() {
							public void run() {

								((ToggleButton) view).setEnabled(true);
							}
						});
					} [/B]else {
						inst.sendKeyDownUpSync(KeyEvent.KEYCODE_POUND);
						Thread.sleep(500);
						inst.sendKeyDownUpSync(KeyEvent.KEYCODE_9);
						Thread.sleep(500);
						[B]runOnUiThread(new Runnable() {
							public void run() {

								((ToggleButton) view).setEnabled(true);
							}
						});
					}[/B]
				} catch (InterruptedException e) {
					Log.d(TAG, "Failed to send keycodes: " + e.getMessage());
				}
			}
		}).start();
	}

onemorechance

A solution on stackoverflow that might suit your needs.

How to set delay in Android onClick function