Array index out of bounds

Tar.Aldarion

Could somebody explain why I am getting this error on the bolded line? The indices contain what I want.

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */
package scjp;

/**
 *
 * @author paul
 */
import java.util.*;
import java.io.*;

class DVDInfo implements Comparable<DVDInfo>{
	String title;
	String genre;
	String leadActor;
	
	DVDInfo(String t, String g, String a){
		title = t; genre = g; leadActor = a;
	}
	
	public String toString(){
		return title + " " + genre + " " + leadActor + "\n";
	}
	
	public int compareTo(DVDInfo d){
		return title.compareTo(d.getTitle());
	}
	
	public String getTitle(){
		return title;
	}
	
	public String getGenre(){
		return genre;
	}
		
	public String getLeadActor(){
		return leadActor;
	}
	
	public void setTitle(String t){
		title = t;
	}
	
	public void setGenre(String g){
		genre = g;
	}
	public void setLeadActor(String l){
		leadActor = l;
	}
	
	
}

public class MyDvd{
	public static void main(String[] args){
		ArrayList<DVDInfo> dvdList = new ArrayList<DVDInfo>();
		populateList(dvdList);
		
		Collections.sort(dvdList);
		System.out.println(dvdList);
		
	}
	
	public static void populateList(ArrayList<DVDInfo> dvdList){
		try{	
			File file = new File("C:\\dvdinfo.txt"); 
			FileReader fr = new FileReader(file);
			BufferedReader br = new BufferedReader(fr);
		
			String s;
			while ((s = br.readLine()) != null){
				String[]tokens = s.split("/");
				[B]dvdList.add(new DVDInfo(tokens[0],tokens[1],tokens[2]));[/B]
                                
			}
			br.close();
		}catch(IOException e){System.out.println("File doesn\'t exist");}
		
	}
	
}

Colonel Panic

Put a breakpoint on s.split("/") and see if it returns an array of length 3? Never trust strings, always check array bounds.

CrazyFish

Maybe post the text file of the dvd info. But I would imagine that one of the tokens is returning null. I would just put a print statement of the three tokens just before you add them and see which one is returning null.

Colonel Panic

It's not that one of the tokens is null...

The correct way to handle this is that you're expecting three token. Check that there are three tokens and if not, you've got an error to handle.

Tar.Aldarion

Woops thanks, a stray ] moved to a new line somehow so there were not 3 tokens on the last line!

Dint spot it because there is a ] in the last line of output.