Brackets in wikipedia links moved outside link

pickarooney

This is kind of trivial and I don't know if it's a boards thing as such but I've noticed that whenever anyone posts a link to a Wikipedia article containing brackets at the end that when the post is submitted the link is incorrectly parsed with the closing bracket put outside the [/url] tag, making an invalid link.

Examples:
http://en.wikipedia.org/wiki/Arrested_Development_(TV_series)
http://en.wikipedia.org/wiki/Ramstein_(disambiguation)

In advanced mode, using the link button, the parsing is OK:
http://en.wikipedia.org/wiki/Guatemala_(disambiguation)

Boards.ie: Danny

pickarooney wrote: »

This is kind of trivial and I don't know if it's a boards thing as such but I've noticed that whenever anyone posts a link to a Wikipedia article containing brackets at the end that when the post is submitted the link is incorrectly parsed with the closing bracket put outside the [/url] tag, making an invalid link.

Examples:
http://en.wikipedia.org/wiki/Arrested_Development_(TV_series)
http://en.wikipedia.org/wiki/Ramstein_(disambiguation)

In advanced mode, using the link button, the parsing is OK:
http://en.wikipedia.org/wiki/Guatemala_(disambiguation)

Cheers for the bug report - it would seem like the url parser isn't able to handle this correctly all right. Will file a bug report and get to it as soon as we can

seamus

It's a "clever" feature so that when I stick a link in brackets (www.google.com), it recognises that the closing bracket isn't part of the link.

Obviously though it fails to recognise when it should be part of the link.

Boards.ie: Danny

Yep, though we could take a look at the parser and see if there are improvements to be made for certain sites (e.g. wikipedia) if not for all sites

pickarooney

If there's an open bracket after the start of the link then include any closed brackets thereafter? Sounds a bit tricky but then you don't get paid for 'easy'.:D

pickarooney

I'm not sure if you changed anything or if Wikipedia changed something but this morning when I followed a link to

http://en.wikipedia.org/wiki/Troll_(Internet

It opened the right page

aidan_walsh

Looks like Wikipedia has a special redirect set up for that page. Probably a common enough hit to warrant it.

Boards.ie: Danny

The quick way around this is to just throw in an underscore after a link that ends with a right-bracket.

The parser for URLs is not simple, the regex is a beast. The issue comes down to using a regular expression to identify if a previous open-bracket was detected in a URL.

It's taken a while and involves a completely new regex for URL parsing, but it should be deployed today or tomorrow and this issue shouldn't crop up anymore.

Rolled back, it hates attachments in [img]tags [/img]

RolandIRL

Love the new prefix on this thread :pac:

Boards.ie: Danny

It very nearly drove me to madness, but I think I've got it cracked.

I'll get the improved new regex URL parser rolled out tomorrow morning and watch for another bug report

Boards.ie: Danny

Rolled out the new new regex there, hopefully this will be the end of it

pickarooney

Looking good. Nice work, Danny