Cant get body onload to fire

John_Mc · 27-02-2009 10:31am #1

Hi,

I have some simple JS that I cant get to fire on my ASP.net Masterpage.

It's the same for FF3 and IE7, havent checked in other browsers yet.

There are no JS errors, just nothing is happening...

<script type="text/javascript">
    function showTerms() {
      alert("got here");
      var termsContainerID = '';

      if ($get('hdnShowTerms') != null)
        termsContainerID = $get('hdnShowTerms').value;
        
      if ($get(termsContainerID) != null) {
        $.modal(document.getElementById(termsContainerID), { overlayId: ('TermsModal-overlay'), containerId: ('TermsModal-container') });
      }
      
    }
  </script>
</head>

  <body onload="showTerms();" >

Anyone see anything wrong with this?

corblimey · 27-02-2009 11:33am

Works fine as is in my FF3 and IE7 although I did have to allow ActiveX content on IE7 before it worked. Could your security settings be stopping it?

<html>
<head>
<script type="text/javascript">
    function showTerms() {
      alert("got here");
      var termsContainerID = '';

      if ($get('hdnShowTerms') != null)
        termsContainerID = $get('hdnShowTerms').value;
        
      if ($get(termsContainerID) != null) {
        $.modal(document.getElementById(termsContainerID), { overlayId: ('TermsModal-overlay'), containerId: ('TermsModal-container') });
      }
      
    }
  </script>
</head>

  <body onload="showTerms();" >
hello
</body>
</html>

(ETA: I get the "got here" alert, obviously nothing else works)

Eoin · 27-02-2009 1:11pm

Works on FF and IE for me as well.

John_Mc · 27-02-2009 1:15pm

Thanks lads, been trying to the past two days to get a JS function onto a page should a server side function decide that on needs to be added. I used the ClientScript Startup method which worked in FF, but caused an "operation aborted" error in IE

I've had to go about things in a completely different way now and it's working. Still dont know why the onload method wasnt called though...

nice1franko · 28-02-2009 8:21pm

AFAIR, the body onload event is a bit flaky (may not fire if any dom elements in it are edited before the event would naturally fire or something)... try document.onload instead.

mewso · 01-03-2009 8:03am

Since we are now in 2009 I thought I would make a few suggestions.

1. Stop using inline javascript in html.
2. Put your script in external js files.
3. Write your script to be unobtrusive.
4. Use a proper well documented method to add load events to your page like the addLoadEvent function or putting your script link at the end of the body content.
5. Please stop using inline javascript in html.

02-03-2009 8:41pm

I'd echo wat musician has said.

Put the onload event in the javascript, not the HTML and you'll be writing much better practice JS.

http://onlinetools.org/articles/unobtrusivejavascript/chapter4.html

Cant get body onload to fire

Comments