php code problem..

deepriver · 10-11-2008 3:35pm #1

Hey boardies!

I am getting the following error message when I complete and submit my HTML form

Parse error: syntax error, unexpected T_STRING in line 1

[/B]the form actually works and the info is delivered to email, but can anyone help me spot what the problem is? Code below

<?php
$toEmail = "shane@email.ie";
$subject = "Call-Back Required";
$name = $_REQUEST;
$fromEmail = $_REQUEST;
$mobile = $_REQUEST ;
$message = "\n Name: ".$_GET["name"]."\n Email: ".$_GET["email"]."\n Mobile: ".$_GET["mobile"]."\n\n";
mail( $toEmail, $subject, $message );
include('thankyou.htm');
?>

danindublin · 10-11-2008 3:50pm

I would say its the dot in line one, maybe try single quotes? (*I am not a php developer - just looks like its the problem*)

Evil Phil · 10-11-2008 4:05pm

Can we see the full code for the thankyou.htm file? It seems to me from what you've said that it is the line include('thankyou.htm'); that is throwing the error.

And you should probably just use single quotes instead of a mixture of the too.

CuLT · 10-11-2008 4:12pm

Evil Phil wrote: »

Can we see the full code for the thankyou.htm file? It seems to me from what you've said that it is the line include('thankyou.htm'); that is throwing the error.

And you should probably just use single quotes instead of a mixture of the too.

If "thankyou.htm" is actually a HTML page then that's why the error is being thrown (can't just include HTML pages in PHP code).

And more conformity with the quotes would also be good practice

deepriver · 10-11-2008 4:14pm

thankyou.htm code Phil

<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE html PUBLIC "-//WAPFORUM//DTD XHTML Mobile 1.0//EN" "http://www.wapforum.org/DTD/xhtml-mobile10.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Cache-Control" content="public"/>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
<title>thank you page</title></head>
<body>
<div id="branding">
<div align="center"><img src="images/banner_200.jpg" alt="" width="200" height="34" /></div>
</div>
/>Thank you for registering you interest, we will contact you shortly</p>
</body>
</html>

Webmonkey · 10-11-2008 4:16pm

Evil Phil wrote: »

Can we see the full code for the thankyou.htm file? It seems to me from what you've said that it is the line include('thankyou.htm'); that is throwing the error.

And you should probably just use single quotes instead of a mixture of the too.

Yep but bare in mind the \n characters will not be expanded in string literals (single quotes).

deepriver · 10-11-2008 4:16pm

CuLT wrote: »

If "thankyou.htm" is actually a HTML page then that's why the error is being thrown (can't just include HTML pages in PHP code).

And more conformity with the quotes would also be good practice

How do I get the php to return a html page? This code actually worked before, just when i moved it to another page in another directory it started going wrong

Webmonkey · 10-11-2008 4:19pm

deepriver wrote: »

How do I get the php to return a html page? This code actually worked before, just when i moved it to another page in another directory it started going wrong

You could do all the sending an error processing , then if all ok do a
[php]header('location: /subdir/thankyou.html');[/php] on top your page (before any output done) and it will display this page

deepriver · 10-11-2008 4:28pm

Webmonkey wrote: »

You could do all the sending an error processing , then if all ok do a
[php]header('location: /subdir/thankyou.html');[/php] on top your page (before any output done) and it will display this page

it didnt like that, same errror message

Webmonkey · 10-11-2008 4:29pm

What's the error. It must be in the PHP script you doing the processing so if that is the case.
By the way, where you have include('thankyou.htm');, you'd put that line. really you should do more server side checks to ensure correct and sufficient details entered. You could simply just have your HTML page start under the closing PHP tag also, nothing wrong with that.

deepriver · 10-11-2008 4:36pm

Webmonkey wrote: »

What's the error. It must be in the PHP script you doing the processing so if that is the case.
By the way, where you have include('thankyou.htm');, you'd put that line. really you should do more server side checks to ensure correct and sufficient details entered. You could simply just have your HTML page start under the closing PHP tag also, nothing wrong with that.

made that change.. put the include at bottom and got

CGI Error

The specified CGI application misbehaved by not returning a complete set of HTTP headers.

Webmonkey · 10-11-2008 4:37pm

Eh? - Where is this script working, where the thank you page - surely not in the cgi-bin. You may have your server set up to interpret html files as Perl.

Strange

deepriver · 10-11-2008 4:39pm

Webmonkey wrote: »

What's the error. It must be in the PHP script you doing the processing so if that is the case.
By the way, where you have include('thankyou.htm');, you'd put that line. really you should do more server side checks to ensure correct and sufficient details entered. You could simply just have your HTML page start under the closing PHP tag also, nothing wrong with that.

the original error is

Parse error: syntax error, unexpected T_STRING in \console\logondetails\webaddress.ie\page\thankyou.htm on line 1

deepriver · 10-11-2008 4:41pm

Webmonkey wrote: »

Eh? - Where is this script working, where the thank you page - surely not in the cgi-bin. You may have your server set up to interpret html files as Perl. Strange

my noggin is fried with this lol.. I should point out I am a very green developer!:O

deepriver · 10-11-2008 4:43pm

is there something wrong with my thankyou.htm page? maybe corrupted or something... as I mentioned, this code worked before on another site very recently, same web servers, copy and past job, updated the urls, form boxes where the same

Parse error: syntax error, unexpected T_STRING in \console\logondetails\webaddress.ie\page\thankyou.htm on line 1

Webmonkey · 10-11-2008 4:44pm

Well htm should not be intepreted anyways. I think your whole server is set up incorrectly or wierdly. Just wait and see if others have opinions here.

Evil Phil · 10-11-2008 7:24pm

I agree with webmonkey, it might be a config thing. How is the server setup to handle htm files? And what kind of webserver are you using?

daymobrew · 11-11-2008 2:56pm

CuLT wrote: »

If "thankyou.htm" is actually a HTML page then that's why the error is being thrown (can't just include HTML pages in PHP code)

The docs for include seem to imply otherwise.

When a file is included, parsing drops out of PHP mode and into HTML mode at the beginning of the target file, and resumes again at the end. For this reason, any code inside the target file which should be executed as PHP code must be enclosed within valid PHP start and end tags.

deepriver - what happens when you comment out the 'include' line? (might as well try to determine if this file is the issue).

oeb · 11-11-2008 3:13pm

Quick and dirty fix

On the first line of thankyou.htm do this
print <<< EOT

And on the last line put

EOT;

The eot has to be at the start of the line. Otherwise a header re-direct will work, just give the file a html extention instead of a PHP one. It may be that php is not set up correctly on your computer and the xml at the top (the <? bit especially) is throwing it off.

EDIT : Or just get rid of the xml decleration at the top.

Webmonkey · 11-11-2008 3:38pm

eob wrote:

The eot has to be at the start of the line. Otherwise a header re-direct will work, just give the file a html extention instead of a PHP one. It may be that php is not set up correctly on your computer and the xml at the top (the <? bit especially) is throwing it off.

This is a good point. Shorthand opening tags for PHP might be enabled so it gets intepreted. Your server is set up to intepret htm pages as PHP. What web server are you using? - In PHP.ini file you can change the short_open_tag true line to short_open_tag false.
Ideally you should also edit the http.conf file in Apache to stop PHP from intpreting htm pages.

deepriver · 12-11-2008 8:35pm

yes apparently the first line of my thankyou.htm document was being interpreted as a php page / code... because it starts with a <?... got it sorted anyhow, so thanks for the responses, much appreciated

CuLT · 12-11-2008 9:19pm

daymobrew wrote: »

The docs for include seem to imply otherwise.

Hmm, can't believe I never came across something so fundamental before. Assumption is the mother of all f*ck ups as they say... Ta.

deepriver · 12-11-2008 10:25pm

coming from a non-tech background.. it seems a bit lame on dotmobi to recommend starting a xhtml page with <? if any interaction with php code is going to screw everything up...

I got a fix on the php code side, but it could have been solved by reverting the html code back to the standard <!DOCTYPE html......

Webmonkey · 12-11-2008 10:32pm

Well it is very uncomon to set a webserver up to interpret htm pages as PHP. So usually it isn't a problem

oeb · 12-11-2008 11:05pm

deepriver wrote: »

coming from a non-tech background.. it seems a bit lame on dotmobi to recommend starting a xhtml page with <? if any interaction with php code is going to screw everything up...

I got a fix on the php code side, but it could have been solved by reverting the html code back to the standard <!DOCTYPE html......

Mostly it's a bit lame to have short tags switched on.
1. It encourages lazy code
2. It interferes with XML

php code problem..

Comments