need a quick bit of help here

miju

figured this would be better here than in webmaster forum, the following line of code is throwing up a syntax error on me

<a href="#" OnClick="window.open('1.html','my_window','width=620, height=435'); onMouseOut="MM_swapImgRestore();"  onMouseOver="MM_swapImage('xx_r9_c16','','images/messages_on.jpg',1);"><img name="xx_r9_c16" src="images/xx_r9_c16.jpg" width="100" height="27" border="0" alt=""></a>

anyone any idea what im missing here?

aidan_walsh

No closing " after onClick.

miju

ah sweet, i really hate debugging :-(

nice one man, mucho appreciated

Karoma

OnClick="window.open('1.html','my_window','width=620, height=435');"
too slow:)

OfflerCrocGod

Use firefox it can catch these errors. Tools -> Javascript Console and then load up your webpage any errors come up in the console and it's easy to fix

Error: unterminated string literal
Source File: javascript: OnClick="window.open('1.html','my_window','width=620, height=435');
Line: 1, Column: 9
Source Code:
OnClick="window.open('1.html','my_window','width=620, height=435');

It's a great help.

seamus

For better compatibility, I recommend you use:

[html]<a href="1.html" target="_blank" OnClick="window.open('1.html','my_window','width=620, height=435');return false;">[/html]
If the client has Javascript enabled, the "return false" stops the window from being opened twice. If the client has Javascript disabled, the window will still open.

Seth Brundle

A decent [text] editor should colour code these also!

Trampas

editplus is a free text editor

Seth Brundle

There was a thread here recently on good free text editors and loads were listed.
Any good editor will have syntax highlighting and should quickly allow the user to spot unterminated strings.

miju

thanks for the help guys, yiz are all legends so yiz are:D