Advertisement
If you have a new account but are having problems posting or verifying your account, please email us on hello@boards.ie for help. Thanks :)
Hello all! Please ensure that you are posting a new thread or question in the appropriate forum. The Feedback forum is overwhelmed with questions that are having to be moved elsewhere. If you need help to verify your account contact hello@boards.ie

Getting a code review?

Options
  • 26-04-2014 3:38am
    #1
    Fenster
    Closed Accounts Posts: 4,763 ✭✭✭


    Is there any better way to get one than to link my project somewhere and tout its superiority? :p

    Less facetiously, if anyone would like to dress me down about my latest project, you can find the link below. Simple HTML/CSS theme, with some jQuery interactivity (gallery/lightbox):

    https://github.com/bhalash/Funcan

    Live version:

    http://peppermint.bhalash.com/funcan/gallery.html


Comments

  • Options
    #2
    Talisman
    Registered Users Posts: 6,027 ✭✭✭Talisman


    Just had a quick look on Github - your JS code is well commented, well done I rarely have the patience.

    One thing I noticed in your HTML is that you are using the time element but you're not specifying the time in a machine readable format.
    <time class="post-date">Tuesday September 15, 2009</time>

    In this case there should be a datetime attribute:
    <time class="post-date" datetime="2009-09-15">Tuesday September 15, 2009</time>


  • Options
    #3
    Fenster
    Closed Accounts Posts: 4,763 ✭✭✭Fenster


    Well spotted, and fixed.


Advertisement